From ddd069b73445f113024c6e1fba6ce7def37ee6c7 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Wed, 3 May 2017 18:21:32 +0900 Subject: [PATCH] Fix bookmark hanger dialog overflow Close #8634 Auditors: Test Plan: 1. Change UI scale on about:preferences#advanced 2. Minimize the window size 3. Click the star icon 4. Make sure the hanger dialog is not broken Test Plan 2: 1. Open about:autofill 2. Click "Add Address" 3. Make sure the autofill dialog is not broken --- app/renderer/components/common/commonForm.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/renderer/components/common/commonForm.js b/app/renderer/components/common/commonForm.js index 81fc7ab0d44..e7caac8c7cf 100644 --- a/app/renderer/components/common/commonForm.js +++ b/app/renderer/components/common/commonForm.js @@ -137,6 +137,9 @@ const styles = StyleSheet.create({ cursor: 'default', width: '100%', maxWidth: globalStyles.spacing.dialogWidth, + minWidth: '310px', + height: 'auto', + maxHeight: '100vh', // #8634: commonStyles.flyoutDialog, userSelect: 'none' // Need a general solution @@ -159,6 +162,7 @@ const styles = StyleSheet.create({ commonFormBookmarkHanger: { maxWidth: globalStyles.spacing.bookmarkHangerMaxWidth, + height: 'initial', // #8634 // Cancel the inherited value from .navbarMenubarFlexContainer, which is 'nowrap'. whiteSpace: 'normal'