From ffa6f8fab7022136a68a010e0f5329ec674c89d6 Mon Sep 17 00:00:00 2001 From: Brian Clifton Date: Fri, 24 Mar 2017 11:27:06 -0700 Subject: [PATCH] Updated npmrc and cibuild and verified this works on macOS Auditors: @bbondy, @bridiver --- .npmrc | 2 +- tools/cibuild.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.npmrc b/.npmrc index dabdc1c7eee..a81dad794a8 100644 --- a/.npmrc +++ b/.npmrc @@ -1,4 +1,4 @@ runtime = node -target = 7.4.0 target_arch = x64 brave_electron_version = 2.57.0 +chromedriver_version = 2.27 diff --git a/tools/cibuild.py b/tools/cibuild.py index 4a678a20754..8d52eba0958 100755 --- a/tools/cibuild.py +++ b/tools/cibuild.py @@ -6,7 +6,7 @@ import os.path MUON_VERSION = '2.57.0' -NODE_VERSION = '7.4.0' +CHROMEDRIVER_VERSION = '2.27' SOURCE_ROOT = os.path.abspath(os.path.dirname(os.path.dirname(__file__))) TARGET_ARCH= os.environ['TARGET_ARCH'] if os.environ.has_key('TARGET_ARCH') else 'x64' os.environ['npm_config_arch'] = TARGET_ARCH @@ -24,9 +24,9 @@ def execute(argv, env=os.environ): def write_npmrc(): data = 'runtime = node\n' \ - 'target = %s\n' \ 'target_arch = %s\n' \ - 'brave_electron_version = %s\n' % (NODE_VERSION, TARGET_ARCH, MUON_VERSION) + 'brave_electron_version = %s\n' \ + 'chromedriver_version = %s\n' % (TARGET_ARCH, MUON_VERSION, CHROMEDRIVER_VERSION) f = open('.npmrc','wb') f.write(data) f.close()