Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Block coin miners by default with Brave shields up #10994

Closed
bbondy opened this issue Sep 17, 2017 · 3 comments
Closed

Block coin miners by default with Brave shields up #10994

bbondy opened this issue Sep 17, 2017 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Sep 17, 2017

This is done once this is merged: brave-experiments/ad-block#74

Testing notes:

  1. Close Brave
  2. Use new test data file uploaded to the PR.
  3. Open Brave
  4. Visit https://cnhv.co/6or
  5. Turn off shieods

Step 4 should not load the page, but if you turn shields down it will.

@bbondy bbondy self-assigned this Sep 17, 2017
@bbondy bbondy changed the title Block coin mining by default Block coin miners by default with Brave shields up Sep 17, 2017
@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 17, 2017
@bbondy
Copy link
Member Author

bbondy commented Sep 18, 2017

This is live now, you can see it even with the currently released build since it is from an adblock definition update.

@srirambv
Copy link
Collaborator

Any specific QA test required?

@bbondy
Copy link
Member Author

bbondy commented Sep 20, 2017

@srirambv yep I had it in the commit but I just updated it in comment 0. Thanks for the ping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.