Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab number is wrongly counted on 'opens a new tab with the location of the entry when double clicked' test #11237

Closed
luixxiul opened this issue Oct 2, 2017 · 2 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 2, 2017

Description

npm run test -- --grep='about:bookmarks double click behavior opens a new tab with the location of the entry when double clicked' fails due to that the tab number is wrongly counted.

Steps to Reproduce

  1. Run BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep='about:bookmarks double click behavior opens a new tab with the location of the entry when double clicked'

Reproduces how often: [What percentage of the time does it reproduce?]
Consistently

Brave Version

about:brave info:

Brave: 0.21.0
V8: 6.1.534.41
rev: e357db4
Muon: 4.4.25
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 61.0.3163.100

Reproducible on current live release:

Additional Information

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 2, 2017

This looks failing only on master.

master: https://travis-ci.org/brave/browser-laptop/jobs/282118449#L3646
0.20.x: https://travis-ci.org/brave/browser-laptop/jobs/282118734#L3695 (other tests are failing)
0.19.x: https://travis-ci.org/brave/browser-laptop/jobs/282119235#L3774 (other tests are failing)

@luixxiul
Copy link
Contributor Author

@cezaraugusto do you think this issue has a similar cause as #11269?

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants