set app user model ID on Windows for taskbar pinning / grouping

[bbondy]

The installer generated with Squirrel will create a shortcut icon with an Application User Model ID in the format of com.squirrel.PACKAGE_ID.YOUR_EXE_WITHOUT_DOT_EXE, examples are com.squirrel.slack.Slack and com.squirrel.code.Code. You have to use the same ID for your app with app.setAppUserModelId API, otherwise Windows will not be able to pin your app properly in task bar.

[luixxiul]

Isn't this bug critical?

[bbondy]

not critical but I thin it can lead to 2 taskbar icons.

[luixxiul]

So this might be related with #1779 (comment)?

[bbondy]

no related to if you have a taskbar icon, and then click that taskbar icon. And a second brave icon appears on the taskbar.

[bbondy]

CC @bsclifton this sounds like something you might like to take.

[bsclifton]

Looks to be already fixed 😄
d98f763#diff-98f0ed24f8f0fed04b7949391f32909e

[bbondy]

I was assuming it could lead to 2 taskbar icons because maybe the exact format mentioned in the first comment wasn't followed (uppercase /lower somewhere maybe or something? )

[bsclifton]

@bbondy after reading more in electron/electron#1954, I think you're exactly right. Basically, it could break the already pinned Brave icon when the auto-updater runs and installs a new version. I have seen this happen before; the old pinned icon turns into a blank document looking icon and then I need to use the desktop shortcut and re-pin the executable

I had mistakenly thought the packaging process was overridden with the value provided by the above commit (since the same file handles squirrel command line params)

[luixxiul]

Does this close #1778?

[bbondy]

yep I think so