Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Implement hamburger menu #218

Closed
bbondy opened this issue Jan 21, 2016 · 7 comments
Closed

Implement hamburger menu #218

bbondy opened this issue Jan 21, 2016 · 7 comments
Assignees

Comments

@bbondy
Copy link
Member

bbondy commented Jan 21, 2016

No description provided.

@diracdeltas
Copy link
Member

is this like on Chrome where the hamburger menu is just a duplicate of commonly-used app menu items?

@diracdeltas
Copy link
Member

screen shot 2016-01-21 at 20 06 58

@bbondy
Copy link
Member Author

bbondy commented Jan 22, 2016

The button itself was in the design spec but not specified what's in it. Something like that makes sense to me.

@bradleyrichter
Copy link
Contributor

Here is a menu definition that captures some of the top-level functions, and also introduces the top level items from the Bravery menu which will soon be used on a per-site basis. I omitted the standard chrome-style zoom and edit items for now to save space, as they are the most known keyboard shortcuts. If we find out that they are needed, we can add them later.

@diracdeltas Please migrate the current windows/mac kbd shortcuts in case these are mislabeled.
(like Exit for example)

brave_hamburger_menu

@jonathansampson
Copy link
Collaborator

Am I correct that the button, for now, is entirely non-operable? I was clicking it, and seeing no response. I suspected it might have been a bug, but this ticket is making me think otherwise :)

@bbondy bbondy assigned bbondy and unassigned diracdeltas Jan 27, 2016
@bbondy
Copy link
Member Author

bbondy commented Jan 27, 2016

snatching this, hope you didn't already start Yan

@bbondy bbondy closed this as completed in 053c1ef Jan 27, 2016
@bbondy
Copy link
Member Author

bbondy commented Jan 27, 2016

The button does nothing before 0.7.10.
It will be fixed in 0.7.10 when we do that release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants