This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix bookmark toolbar not showing on first bookmark from context menu #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor): - Menu status for is site bookmarked is handled here, making it reliable - Bookmarks toolbar showing for first time is handled here too. Fixes #3331 Fixed error that was happening in entry.js
|
++ thanks! |
This was referenced Aug 25, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
This was referenced Aug 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Fixed error that was happening in entry.js
Moved the following to AddEditBookmark.js (taking logic out of navigator):