Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Preferences : Payments : Add Funds modal alignment appears to be off for Brave wallet address #3378

Closed
alexwykoff opened this issue Aug 24, 2016 · 5 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When opening the Add Funds modal, it appears as though the Brave wallet address is pushed to the right by an empty div.

Expected behavior:
The address info should be either centered below the two prominent columns or left-aligned.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X.
  • Brave Version:
    0.11.6 pre-beta3
  • Steps to reproduce:
    1. Enable Brave Payments.
    2. Create a wallet.
    3. Click on Add Funds.
  • Screenshot if needed:
    screen shot 2016-08-24 at 10 52 49 am
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.11.6dev milestone Aug 24, 2016
@alexwykoff
Copy link
Contributor Author

@bradleyrichter would you have a spec handy for this?

@bradleyrichter
Copy link
Contributor

The address line is breaking. If we must show the string of randomized characters, then we may need to change this layout.

@mrose17 Is the character count fixed? Or can the string be longer?

Can we stack it into 4 lines?

@mrose17
Copy link
Member

mrose17 commented Aug 24, 2016

a bitcoin address may be upto 35 characters. it is unwise to break it up. it should appear as one string without any whitespace. it is designed to be selected in a single click (no punctuation characters, whitespace, etc., are allowed in the address). cf., https://en.bitcoin.it/wiki/Address

@diracdeltas
Copy link
Member

diracdeltas commented Aug 24, 2016

i fixed this in master by making the font size smaller but i have no idea if it's broken on other screen resolutions

@diracdeltas
Copy link
Member

calling this closed by bbc4d90#diff-4b50ff14dadc9756719a577a72f520d6R581

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants