Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Duping texts on ledger welcome page in other languages than English #3379

Closed
luixxiul opened this issue Aug 24, 2016 · 8 comments
Closed

Duping texts on ledger welcome page in other languages than English #3379

luixxiul opened this issue Aug 24, 2016 · 8 comments

Comments

@luixxiul
Copy link
Contributor

Did you search for similar issues before submitting this one? I think someone has reported this, but I cannot find it though I searched for it as much as possible.

Describe the issue you encountered: If I change the language setting to other languages than English, duping texts are displayed on ledger welcome page. Confirmed on the Japanese setting.

Expected behavior: paymentsWelcomeText3 should be removed and paymentsWelcomeTextBold should be translatable.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS
  • Brave Version: 0.11.6 beta3
  • Steps to reproduce:
    1. Change your language setting in Brave into Japanese
    2. Open about:preferences and select Payments
  • Screenshot if needed:
    screenshot 2016-08-25 1 09 06
  • Any related issues:
@luixxiul
Copy link
Contributor Author

Setting a milestone for now as it seems easy to fix.

@bbondy
Copy link
Member

bbondy commented Aug 25, 2016

/cc @diracdeltas

@bridiver bridiver self-assigned this Aug 25, 2016
@bridiver
Copy link
Collaborator

everything appears to be configured correctly, it's just missing the translation for paymentsWelcomeTextBold

@luixxiul
Copy link
Contributor Author

Has paymentsWelcomeText3 been removed or replaced with something else already?

@bridiver
Copy link
Collaborator

@bbondy @luixxiul says there is a transifex 502 error and I have no idea what to do about that

@bridiver bridiver removed their assignment Aug 25, 2016
@luixxiul
Copy link
Contributor Author

Updating translation should solve the issue. Let me check.

@luixxiul
Copy link
Contributor Author

I confirmed it fixed the issue. Will push a PR for translation update.

@diracdeltas
Copy link
Member

thanks @luixxiul

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants