Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disabling Payments doesn't retain states #3612

Closed
srirambv opened this issue Aug 31, 2016 · 9 comments
Closed

Disabling Payments doesn't retain states #3612

srirambv opened this issue Aug 31, 2016 · 9 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Aug 31, 2016

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Disabling Payments doesn't retain states

Expected behavior:
Disabling and enabling payment should retains states

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64, OpenSuse 42.1
  • Brave Version:
    0.11.6 RC2
  • Steps to reproduce:
    1.
    2.
    3.
  • Screenshot if needed:
    paymnet
  • Any related issues:
@srirambv
Copy link
Collaborator Author

cc: @bbondy @diracdeltas @BrendanEich

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

I don't think we have to block on ledger state being lost if they toggle beta on/off.

@mrose17
Copy link
Member

mrose17 commented Aug 31, 2016

@bbondy - i agree

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

I'll most to the next hotfix

@bbondy bbondy added this to the 0.11.7dev milestone Aug 31, 2016
@diracdeltas
Copy link
Member

Does the ledger synopsis come back if you open a new site like nytimes.com? For me state is retained, but the ledger doesn't see the synopsis until a new navigation event occurs.

At least in the screencap it appears the wallet state is preserved.

@srirambv
Copy link
Collaborator Author

@diracdeltas No it doesn't come back after navigating to a new site as well.

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

ETA on this? It's possible we'll do an RC3 and if so we could include it.

@mrose17
Copy link
Member

mrose17 commented Sep 1, 2016

has anyone invoked the browser with LEDGER_VERBOSE=true ... to see what it thinks it is doing?

@bbondy bbondy modified the milestones: 0.12.1dev, 0.12.0dev Sep 3, 2016
@srirambv
Copy link
Collaborator Author

srirambv commented Sep 7, 2016

Could not replicate the issue on 0.12.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants