Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add clearAutocompleteData & clearAutofillData to clearBrowsingDataPanel and clear on shutdown #3706

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #3458
required brave/muon#53

Auditors: @bridiver, @bbondy

Test Plan:
For autocomplete data in clearBrowsingDataPanel:

  1. Go to site contains form and submit form after input some value
  2. Double click the input field to make sure it popup the value you previous input
  3. Go to "about:preferences#security" and click "Clear Browsing Data Now..."
  4. Toggle on "Autocomplete data" and click "Clear"
  5. Go previous site you submitted form
  6. Double click the input field should popup nothing

For autocomplete data clear on shutdown:

  1. Go to site contains form and submit form after input some value
  2. Double click the input field to make sure it popup the value you previous input
  3. Go to "about:preferences#security" and toggle on "Autocomplete data"
  4. Quit brave and relaunch it
  5. Go previous site you submitted form
  6. Double click the input field should popup nothing

For autofill data in clearBrowsingDataPanel:

  1. Add address and credit card in "about:autofill"
  2. Go to the site you usually verify autofill and verify it
  3. Go to "about:preferences#security" and click "Clear Browsing Data Now..."
  4. Toggle on "Autofill data" and click "Clear"
  5. Go previous site you verify autofill
  6. Double click the input field should popup nothing

For autofill data clear on shutdown:

  1. Add address and credit card in "about:autofill"
  2. Go to the site you usually verify autofill and verify it
  3. Go to "about:preferences#security" and toggle on "Autofill data"
  4. Quit brave and relaunch it
  5. Go previous site you verify autofill
  6. Double click the input field should popup nothing

…el and clear on shutdown

fix brave#3458
required brave/muon#53

Auditors: @bridiver, @bbondy

Test Plan:
For autocomplete data in clearBrowsingDataPanel:
1. Go to site contains form and submit form after input some value
2. Double click the input field to make sure it popup the value you previous input
3. Go to "about:preferences#security" and click "Clear Browsing Data Now..."
4. Toggle on "Autocomplete data" and click "Clear"
5. Go previous site you submitted form
6. Double click the input field should popup nothing

For autocomplete data clear on shutdown:
1. Go to site contains form and submit form after input some value
2. Double click the input field to make sure it popup the value you previous input
3. Go to "about:preferences#security" and toggle on "Autocomplete data"
4. Quit brave and relaunch it
5. Go previous site you submitted form
6. Double click the input field should popup nothing

For autofill data in clearBrowsingDataPanel:
1. Add address and credit card in "about:autofill"
2. Go to the site you usually verify autofill and verify it
3. Go to "about:preferences#security" and click "Clear Browsing Data Now..."
4. Toggle on "Autofill data" and click "Clear"
5. Go previous site you verify autofill
6. Double click the input field should popup nothing

For autofill data clear on shutdown:
1. Add address and credit card in "about:autofill"
2. Go to the site you usually verify autofill and verify it
3. Go to "about:preferences#security" and toggle on "Autofill data"
4. Quit brave and relaunch it
5. Go previous site you verify autofill
6. Double click the input field should popup nothing
@bbondy
Copy link
Member

bbondy commented Sep 8, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear Autofill option in the Clear browsing data modal
4 participants