This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Context menu search respects session setting of current tab #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tabs opened by Search Image or Search for ... will open with the same session and privacy settings as the tab it was opened from. Fix brave#3662
|
Great, thanks! |
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fixed right click to search not respecting session setting of current tab
New tabs opened by Search Image or Search for ... will open with the same session and privacy settings as the tab it was opened from.
Test Plan:
New tabs opened by Search Image or Search for ... will open with the same session and privacy settings as the tab it was opened from.
Fix #3662
I didn't write tests as I didn't see any related to the context menu, if I need to please show me an example and I can ammend my commit. This is my first time contributing so please inform me of any mistakes I have made!