This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
dialog is cropped at low resolution #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| .modal { | |||
| opacity: 1; | |||
| overflow: scroll; | |||
There was a problem hiding this comment.
I don't think you always want to show a scrollbar on windows here and on mac depending on the setting. I think you want overflow: auto right?
jkup
force-pushed
the
dialog-cropped
branch
from
9c635ff
to
5ef2bb3
Compare
|
Thx |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #3879
Test Plan:
Open the 'Add Funds' dialog with a very small browser window and make sure you can scroll around and interact / see all the dialog.
@bradleyrichter I tried centering it vertically and horizontally but it ends up looking really bad on small screen. I think the best approach is just to allow scrolling.