Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Button icons are style-wonked. Must fix. #3917

Closed
bradleyrichter opened this issue Sep 12, 2016 · 4 comments · Fixed by #3937
Closed

Button icons are style-wonked. Must fix. #3917

bradleyrichter opened this issue Sep 12, 2016 · 4 comments · Fixed by #3937
Assignees
@jkup
Labels
bug design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Milestone
0.12.1dev

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Sep 12, 2016 •
edited
Loading

Reload and BM at least...

image

image

also effects home, noscript per @diracdeltas
image
@bradleyrichter bradleyrichter added bug design A design change, especially one which needs input from the design team. Major labels Sep 12, 2016
@bradleyrichter bradleyrichter added this to the 0.12.1dev milestone Sep 12, 2016
@bbondy
Copy link
Member

bbondy commented Sep 12, 2016

/cc @bridiver

@bbondy bbondy mentioned this issue Sep 12, 2016
Closed
@bridiver
Copy link
Collaborator

bridiver commented Sep 12, 2016 •
edited
Loading

the offset is wrong even with all extensions disabled so I think it's something else. If no extension buttons are active it doesn't insert any new elements or css

@diracdeltas diracdeltas mentioned this issue Sep 12, 2016
Closed
@diracdeltas
Copy link
Member

same for home button and noscript. #3934

@jkup
Copy link
Contributor

jkup commented Sep 12, 2016

Will move conversation into the PR.

@jkup jkup mentioned this issue Sep 12, 2016
Merged
4 tasks
This was referenced Sep 14, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkup jkup

Labels
bug design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.1dev
Development

Successfully merging a pull request may close this issue.

Button icons are style-wonked brave/browser-laptop
8 participants
@bridiver @jkup @diracdeltas @bbondy @alexwykoff @luixxiul @bradleyrichter @srirambv