This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
use origin for the notification message and for site settings and cho… #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose tabs to display on based on mainFrameUrl don't allow Brave to display notifications without permission remove unnecessary password copied notifications cc @bbondy @diracdeltas fix #3877
|
fix #3962 |
|
this causes some of the notificationBar tests to fail |
| @@ -367,7 +374,7 @@ function registerPermissionHandler (session, partition) { | |||
| cb(result) | |||
| if (persist) { | |||
| // remember site setting for this host over http(s) | |||
| appActions.changeSiteSetting(getOrigin(url), permission + 'Permission', result, isPrivate) | |||
| appActions.changeSiteSetting(origin, permission + 'Permission', result, isPrivate) | |||
There was a problem hiding this comment.
need to strip the trailing / from origin for backwards compatibility; i think this is why tests are breaking
There was a problem hiding this comment.
hence why getOrigin was necessary before
'Brave Browser' works with getSiteSettingsForHostPattern but not getSiteSettingsForURL. Auditors: @bridiver Test Plan: Covered by automated test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Test Plan:
The changes for Brave Browser notifications aren't currently testable because we don't get the mainFrameUrl for notifications yet, but I have tested them with a local hack
don't allow Brave to display notifications without permission
remove unnecessary password copied notifications
cc @bbondy @diracdeltas
fix #3877