Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Flash content not loaded in Private window #3998

Closed
srirambv opened this issue Sep 14, 2016 · 3 comments
Closed

Flash content not loaded in Private window #3998

srirambv opened this issue Sep 14, 2016 · 3 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 14, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Visit any site which has flash content running. Flash placeholder is shown but selecting allow once/allow for 1 week doesn't load flash content in the private tab

Expected behavior:
Should run flash content when allow is selected

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.1 RC1
  • Steps to reproduce:
    1. Visit any site with flash content in it on private tab
    2. Select Allow Once/Allow for 1 week in the placeholder
    3. Page refreshes but doesn't load the flash content. Shows could not load plugin
    4. Close the private tab and open the same site in a normal tab flash video automatically starts since its allowed in preferences.
  • Screenshot if needed:
    2
  • Any related issues:

cc: @diracdeltas

@diracdeltas
Copy link
Member

fixed in 45b3e64

@alexwykoff
Copy link
Contributor

This did not pass on Windows 7 x64 for 0.12.3 RC6
private_tab_flash

@diracdeltas
Copy link
Member

@alexwykoff that's because 45b3e64 isn't in the dev-channel branch

cc @bbondy; i think this is fine to release but definitely doesn't block the RC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants