Navigating to URL causes UrlBar to "blink" and yield wrong url results

[Sh1d0w]

Did you search for similar issues before submitting this one?

No

Describe the issue you encountered:

Currently when you use the autocmplete to go to another website, when you hit eneter the url blinks quickly - first displaying the current address you are on (despite the fact you typed completely distinct address) and after a second jumps to the new one and starts loading.

This means if you are typing fast and you accidentaly hit Enter twice you will stay on the same page, because when the old url blinks and you hit enter for second time, Brave thinks you want to go to another page (in that case the current one)

Here is a POC http://webm.land/media/E0Fn.webm

Expected behavior:

URL bar text should not blink and revert your url when you hit enter.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All
• Brave Version:
  0.12.1
• Steps to reproduce:
  1. Open brave.com
  2. Start typing github in the url bar
  3. When the autocomplete appears click Enter twice in even intervals
• Screenshot if needed:
  http://webm.land/media/E0Fn.webm
• Any related issues:

[decode-dev]

Present in Brave 0.12.1

[diracdeltas]

pretty sure the flash occurs in the amount of time that it takes windowState.activeFrame.navbar.urlbar.location to get updated after the enter key is pressed. if so, we can either do performance debugging on the windowstate to make component updates propagate faster, or we can add a setTimeout to have the urlbar location update after enter is pressed (hacky).

[bsclifton]

This appears to be fixed