Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

HTTPS count shown even when its disabled #4300

Closed
srirambv opened this issue Sep 26, 2016 · 2 comments · Fixed by #4145
Closed

HTTPS count shown even when its disabled #4300

srirambv opened this issue Sep 26, 2016 · 2 comments · Fixed by #4145

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
HTTPS count shown even when its disabled

Expected behavior:
Should not show any count when HTTPS is disabled

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.2 RC4
  • Steps to reproduce:
    1. Visit http://travelchannel.com/video
    2. Disable HTTPS Everywhere from bravery panel
    3. HTTPS Everywhere count is still shown when its disabled.
  • Screenshot if needed:
    image
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Sep 26, 2016

cc @diracdeltas that probably means it's not disabling.

@diracdeltas diracdeltas self-assigned this Sep 26, 2016
@diracdeltas
Copy link
Member

chromium recently changed their definition of firstPartyUrl, so it can no longer be used as the main frame URL. confirmed that this is fixed by #4145.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants