Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression: Bookmarks toolbar - Adding bookmarks to folders does not update the view #4420

Closed
alexwykoff opened this issue Oct 1, 2016 · 4 comments
Labels
feature/bookmarks needs-info Another team member needs information from the PR/issue opener. QA/checked-Win64 QA/no-qa-needed regression
Milestone

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
When adding a bookmark to a folder, it appears as though the system did nothing when in fact it moved the bookmark.

Expected behavior:
When adding a bookmark to a folder, it should disappear from the toolbar view since it is now hidden in the folder.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on Windows 7 x64
  • Brave Version:
    0.12.3 RC5
  • Steps to reproduce:
    1. Create some bookmarks and a folder in the bookmarks toolbar
    2. Add a bookmark to a folder
  • Screenshot if needed:
    move_bookmark_into_folder
  • Any related issues:
@bsclifton
Copy link
Member

@alexwykoff just to confirm, this behavior worked in 0.12.1? Curious because I can't repro w/ 0.12.3 RC5

@bbondy
Copy link
Member

bbondy commented Oct 1, 2016

@alexwykoff ditto I can't repro. Maybe we need Steps to Reproduce that involves doing an import from chrome or bookmarks or something? Maybe only triggered when 2 of the same imports? Need some additional steps. If it's something strange we don't need to respin rc5.

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Oct 1, 2016
@alexwykoff
Copy link
Contributor Author

I moved the brave folder away and attempted to repro, also attempted to see if an upgrade scenario caused the issue. Could not reproduce for either.

@alexwykoff
Copy link
Contributor Author

Closing this as DNR. If It is found again, I will reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/bookmarks needs-info Another team member needs information from the PR/issue opener. QA/checked-Win64 QA/no-qa-needed regression
Projects
None yet
Development

No branches or pull requests

4 participants