Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Save the window size (width, height) and use it when restoring from s… #4482

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Save the window size (width, height) and use it when restoring from s… #4482

merged 1 commit into from
Oct 4, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Save the window size (width, height) and use it when restoring from session

Fixes #4385

Auditors: @bridiver @BrendanEich

Test Plan:

  1. Open 2 windows
  2. Resize windows to be different sizes than each other. Maybe window 1 is 300 wide and 800 tall, window 2 is 600 wide and 400 tall
  3. Quit Brave
  4. Re-launch Brave
  5. windows should be restored to the same position and shuld be the same size

…ession

Fixes #4385

Auditors: @bridiver @BrendanEich

Test Plan:
1) Open 2 windows
2) Resize windows to be different sizes than each other. Maybe window 1 is 300 wide and 800 tall, window 2 is 600 wide and 400 tall
3) Quit Brave
4) Re-launch Brave
5) windows should be restored to the same position and shuld be the same size
@bsclifton bsclifton added this to the 0.12.4dev milestone Oct 3, 2016
@Sh1d0w
Copy link

Sh1d0w commented Oct 4, 2016

@bsclifton I wonder if your PR fixes #3754 ? Can you please check the steps provided since I am not able to do so in the next few days :)

@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants