Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix overflow for URL autocomplete on Windows #4582

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Fix overflow for URL autocomplete on Windows #4582

merged 1 commit into from
Oct 6, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 6, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests). N/A
  • Ran git rebase -i to squash commits (if needed).
  • removes padding (not required after accepting Minor toolbar visual refinement suggestions #4400)
  • includes hardcoded size of menubar in offset calculation

Fixes #4539

Auditors: @bbondy @luixxiul

screenshots

before padding removed (5px top and 5px left of URL bar)

screen shot 2016-10-06 at 1 52 53 am

after padding removed

screen shot 2016-10-06 at 1 52 21 am

new URL autocomplete size with menubar open

screen shot 2016-10-06 at 1 31 56 am

- removes padding (not required after accepting #4400)
- includes hardcoded size of menubar in offset calculation

Fixes #4539

Auditors: @bbondy @luixxiul
@bsclifton
Copy link
Member Author

I tried to get a more approximate height using:
Number.parseInt(window.getComputedStyle(document.querySelector('.menubarContainer')).getPropertyValue('height', 30), but it returned the height of the entire window.

I'll look into this more tomorrow (it can be fixed in a follow up 😄)

@bbondy
Copy link
Member

bbondy commented Oct 6, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants