Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger list should not have maximum height #4616

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 7, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4537

Test Plan:

Instead of a fixed-height box with it's own scroll. The entire Payments page should scroll if you have enough publishers.

screen shot 2016-10-07 at 3 11 06 pm

@jkup jkup added the design A design change, especially one which needs input from the design team. label Oct 7, 2016
@jkup jkup added this to the 0.12.5dev milestone Oct 7, 2016
@diracdeltas
Copy link
Member

i added the fixed-height thing because it was in one of @bradleyrichter's original design specs. just making sure he is ok with this change

@jkup
Copy link
Contributor Author

jkup commented Oct 7, 2016

@diracdeltas totally. People were complaining that they didn't know you could scroll so he suggested this change here: #3888 (comment)

@diracdeltas
Copy link
Member

ah ok, cool

@diracdeltas
Copy link
Member

lgtm, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger list should not have maximum height
4 participants