-
Notifications
You must be signed in to change notification settings - Fork 975
Create a tags.less file with global element styling #5094
Comments
Sounds great, but maybe call it global.less? Just not sure what tags means. |
Yeah that sounds good.. I stole the tags name from bootstrap but global makes more sense. |
Love this! It shouldn't be too hard to go through the styles, let me know if you all want to do a 30 min Google hangout and check it out together 😄 (if not, it's all good, I'd be up for reviewing) |
This should be closed right? Just making sure but I think so. |
Sorry, yep! |
Please specify QA steps if any. If not, please label |
@jkup I think putting the steps in the original post of the PR is correct (which you totally did). One thing that couldn't hurt: we can do to make it visually pop out at you by putting it inside a header tag using markdown. Something like testing
|
@jkup my bad I just missed it as there isn't a linked commit to this issue. |
I mean because there was no auto-closing words in the commit 72174bb, it was not referred to this issue. I've noticed the referred PR but I was looking for the commit. |
This relates to the meeting @bradleyrichter and I had regarding #4884
Right now we don't have many global styles for elements which means they need specific sets of classes to work properly. We should create a new less file with just the basic Brave stylings for elements like a, button, input, etc.
Most of the CSS is done it's just buried in a class but I think it would make development a lot easier to pull it out so those elements always get some styling.
The text was updated successfully, but these errors were encountered: