Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Create a tags.less file with global element styling #5094

Closed
jkup opened this issue Oct 24, 2016 · 11 comments
Closed

Create a tags.less file with global element styling #5094

jkup opened this issue Oct 24, 2016 · 11 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64

Comments

@jkup
Copy link
Contributor

jkup commented Oct 24, 2016

This relates to the meeting @bradleyrichter and I had regarding #4884

Right now we don't have many global styles for elements which means they need specific sets of classes to work properly. We should create a new less file with just the basic Brave stylings for elements like a, button, input, etc.

Most of the CSS is done it's just buried in a class but I think it would make development a lot easier to pull it out so those elements always get some styling.

@jkup jkup added the design A design change, especially one which needs input from the design team. label Oct 24, 2016
@jkup jkup added this to the 0.12.8dev milestone Oct 24, 2016
@jkup jkup self-assigned this Oct 24, 2016
@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

Sounds great, but maybe call it global.less? Just not sure what tags means.

@jkup
Copy link
Contributor Author

jkup commented Oct 25, 2016

Yeah that sounds good.. I stole the tags name from bootstrap but global makes more sense.

@bsclifton
Copy link
Member

bsclifton commented Oct 25, 2016

Love this! It shouldn't be too hard to go through the styles, let me know if you all want to do a 30 min Google hangout and check it out together 😄 (if not, it's all good, I'd be up for reviewing)

@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Oct 29, 2016
@jkup jkup mentioned this issue Nov 7, 2016
4 tasks
@jkup jkup modified the milestones: 0.12.10 release , 0.12.9dev Nov 8, 2016
@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

This should be closed right? Just making sure but I think so.
I think commit message needs Fix #x and Fix #y explicitly to close both auto btw.

@bbondy bbondy closed this as completed Nov 17, 2016
@jkup
Copy link
Contributor Author

jkup commented Nov 17, 2016

Sorry, yep!

@luixxiul
Copy link
Contributor

Please specify QA steps if any. If not, please label qa/no qa needed, thanks.

@jkup
Copy link
Contributor Author

jkup commented Nov 21, 2016

@luixxiul QA steps are mentioned in the PR #5442

Am I doing this wrong? Can I make it easier?

@bsclifton
Copy link
Member

bsclifton commented Nov 21, 2016

@jkup I think putting the steps in the original post of the PR is correct (which you totally did). One thing that couldn't hurt: we can do to make it visually pop out at you by putting it inside a header tag using markdown. Something like

testing

  1. step 1
  2. step 2

@luixxiul
Copy link
Contributor

@jkup my bad I just missed it as there isn't a linked commit to this issue.

@jkup
Copy link
Contributor Author

jkup commented Nov 22, 2016

@luixxiul no problem, what does that mean though? This commit #5442 links to this issue

@luixxiul
Copy link
Contributor

I mean because there was no auto-closing words in the commit 72174bb, it was not referred to this issue. I've noticed the referred PR but I was looking for the commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

6 participants