Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Switch search engines locale based on languages #5180

Closed
luixxiul opened this issue Oct 27, 2016 · 3 comments
Closed

Switch search engines locale based on languages #5180

luixxiul opened this issue Oct 27, 2016 · 3 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/search l10n wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 27, 2016

Expected behavior: Switch search engines locale based on languages. Japanese users generally want to use https://amazon.co.jp instead of https://amazon.com, for example.

@luixxiul luixxiul added this to the 1.0.0 milestone Oct 27, 2016
@luixxiul luixxiul changed the title Switch search engines based on languages Switch search engines locale based on languages Oct 27, 2016
@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

/cc @bradleyrichter it seems like region selection matters for things like adblock as well. In your opinion should it be tied to the language selection? Should we be combining this type of thing into a generic region selection or just allow you to configure it?

@bradleyrichter
Copy link
Contributor

Sure. Let's connect regional features that make sense. A user can always override the setting or even the language selection. We should add some note:text in the language area though.

@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 3, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 3, 2018
@bsclifton
Copy link
Member

This should be addressed in brave-core with the OpenSearch functionality built in (ex: we won't be providing US specific search engines to anyone; engines they visit (which are localized) get added to aggregated list)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/search l10n wontfix
Projects
None yet
Development

No branches or pull requests

5 participants