Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar drops last 2 characters when typing fast (not related to auto suggestions or history) #5189

Closed
bradleyrichter opened this issue Oct 27, 2016 · 7 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Oct 27, 2016

Start with a new tab.

1 type a new URL (not already in history) in a normal, but fast cadence.

2 hit enter to commit the string.

3 Notice that the "om" in ".com" was missing.

View the GIF recording and open the file in Mac Preview. This will reveal frames where an unwanted sequence is occurring which may be causing the dropped characters.

(gif shows same URL entered in same cadence in chrome with no issues)

missingcharacters_in_url

cc @diracdeltas
cc @bbondy

@bradleyrichter
Copy link
Contributor Author

actual frames from GIF file above:

image

image

image

image

image

@jkup
Copy link
Contributor

jkup commented Oct 27, 2016

Is this a dupe of #4731? If so then the fix is in master!

@bradleyrichter bradleyrichter changed the title URL bar drops last 2 characters when typing fast, other problems URL bar drops last 2 characters when typing fast (not related to auto suggestions or history) Oct 28, 2016
@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

Brad reproduced again so still valid, but seems things changed with the sequence of GIF frames when you hit enter.

@bradleyrichter
Copy link
Contributor Author

It doesn't seem to happen with random characters. Only in the suffix.

missingcharacters_in_url2

missingcharacters_in_url3

@bradleyrichter
Copy link
Contributor Author

image

image

image

@mideava
Copy link

mideava commented Oct 29, 2016

I have the same problem, but I only lose the last single character. For example, when I type a ".org" domain fast enough, Brave supresses the "g" and adds the final "/", so I end up with ".or/".

@BrendanEich
Copy link
Member

Is there something sampling .length on the string in the URL bar in a racy way, then using that later to truncate the string? Just a guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.