Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payments advance settings button is not hidden when payment is disabled #5384

Closed
srirambv opened this issue Nov 4, 2016 · 0 comments
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 4, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Payments advance settings button is not hidden when payment is disabled on 0.12.8 builds. Verified on 0.12.7 and its hidden after disabling payments

Expected behavior:
Payments advance settings button should

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.12.8 Preview1,2,3 RC1

  • Steps to reproduce:

    1. Enable payments
    2. Create wallet to enable advanced settings button
    3. Disable payments, advance settings button is still shown.
    4. Click on the advance settings button with payments disabled, nothing happens, enable payments now shows the advance settings modal
  • Screenshot if needed:
    advbutton

  • Any related issues:

cc: @jkup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants