Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

increase tabs height by 3 px #5978

Closed
bradleyrichter opened this issue Dec 2, 2016 · 5 comments
Closed

increase tabs height by 3 px #5978

bradleyrichter opened this issue Dec 2, 2016 · 5 comments
Labels
Milestone

Comments

@bradleyrichter
Copy link
Contributor

Currently we are winning the "browser-toolbars smallest stack height" award but recent feedback for users on high-res laptops have suggested that tabs are difficult to click on.

Usability trumps "minimal height" in most cases so adding back 3 px to the tab height will improve the click region without giving up our award completely.

Doing this requires small changes in about 8-10 places given the current structure.

In the future, we would be able to offer "compact mode" and "normal mode" in preferences simply by changing a variable.

Today we just need 3 more px.

@cndouglas
Copy link

Original feedback: #5683

@cndouglas
Copy link

@bradleyrichter @bsclifton Does #6032 fix this?

@bradleyrichter
Copy link
Contributor Author

@liunkae it does, but solving the original feedback will probably need a lot more work to provide a large-mode for these hi-res or vision impaired situations.

@cndouglas
Copy link

OK, so how about we close this and leave #5683 open.

@bradleyrichter
Copy link
Contributor Author

I made this issue for the sole purpose of having an issue to associate with the PR. : )

So, yes, closing now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants