Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add pref setting to "always allow" full screen view #5979

Closed
bradleyrichter opened this issue Dec 2, 2016 · 3 comments
Closed

add pref setting to "always allow" full screen view #5979

bradleyrichter opened this issue Dec 2, 2016 · 3 comments

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Dec 2, 2016

Test Plan:

  1. go to about:preferences#security
  2. find new fullscreen select setting, hit "always allow"
  3. go to https://vimeo.com, open fullscreen
  4. fullscreen should be open without notification prompt
  5. Go back to fullscreen setting
  6. Disable with "always ask"
  7. Go to https://vimeo.com or any other video website
  8. Make video fullscreen, notification should open

QA note:

  1. When notification for fullscreen is set to "deny", even without "remember this decision" checkbox marked, option is stored and you can't undo. Bug wasn't introduced by this PR and was filled under Denying fullscreen mode always remember decision until browser restart #7010 with proper STR.

original issue text

Adding this option will allow a user to override the default for full-screen requests.

The default will still remain as "Always ask".

image

Menu choices:

"Always ask"
"Always allow"

@bradleyrichter
Copy link
Contributor Author

I'll make a separate issue for changes to the alert bar which are waiting on this new setting.

image

@bsclifton
Copy link
Member

@cezaraugusto would you be up for grabbing this one?

@abhibeckert
Copy link

abhibeckert commented Jan 8, 2017

Related, the "Example.com entered full screen mode. Press ESC to exit" message is annoying:

  • I know I'm in full screen mode – I just clicked an "enter full screen" button.
  • I know how to exit full screen – I've been doing it for years.
  • The message is large and covers part of the page content and cannot be hidden, all I can do is wait for it to go away, which takes several seconds.

I think the message should be removed completely. What reason is there to keep it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants