Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking on block script icon doesn't show notification to allow scripts to be loaded #6680

Closed
srirambv opened this issue Jan 16, 2017 · 2 comments · Fixed by #6681
Closed

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Clicking on block script icon doesn't show notification to allow loading of scripts

Expected behavior:
Should show the message to allow scripts to be loaded

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev dc4f0fd
    Verified on 0.12.15 shows notification to allow scripts to be load

  • Steps to reproduce:

    1. Visit https://brainbondy.com
    2. Enable Block scripts from shields
    3. Click on the Block script icon in URL bar, nothing happens
  • Screenshot if needed:
    blockscript

  • Any related issues:

@luixxiul
Copy link
Contributor

I unintentionally introduced the regression here: 19360c1#diff-02c4b23ad267fe636760179e32fa29ceR842

@luixxiul
Copy link
Contributor

Test plan: #6681 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants