Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Specify the font-size of textarea #6852

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Specify the font-size of textarea #6852

merged 1 commit into from
Feb 9, 2017

Conversation

luixxiul
Copy link
Contributor

Closes #6851

Auditors: @bradleyrichter

Test Plan:

  1. Open about:adblock
  2. Input some strings in the custom filters area
  3. Make sure they are readable
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Specify the font-size of textarea
5ca8ee4 
Closes #6851

Auditors:

Test Plan:
1. Open about:adblock
2. Input some strings in the custom filters area
3. Make sure they are readable
@luixxiul luixxiul added feature/adblock polish Nice to have — usually related to front-end/visual tasks. settings labels Jan 25, 2017
@bsclifton bsclifton added this to the 0.13.2 milestone Jan 26, 2017
@luixxiul luixxiul modified the milestones: 0.13.2, 0.13.3 Jan 31, 2017
@cndouglas cndouglas self-requested a review February 4, 2017 06:43
cndouglas
cndouglas approved these changes Feb 4, 2017
View reviewed changes
Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@cndouglas
Copy link

Comparison

0.13.1:

With this PR:

@bsclifton bsclifton modified the milestones: 0.13.3, 0.13.4 Feb 9, 2017
@bsclifton bsclifton merged commit 1a93646 into brave:master Feb 9, 2017
@luixxiul luixxiul deleted the fix-fontsize-textarea branch February 10, 2017 13:27
This was referenced Feb 11, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cndouglas cndouglas cndouglas approved these changes

Assignees

@luixxiul luixxiul

Labels
feature/adblock polish Nice to have — usually related to front-end/visual tasks. settings
Projects
None yet
Milestone
0.13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@luixxiul @cndouglas @bsclifton