Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor buttons with Aphrodite #7168

Closed
luixxiul opened this issue Feb 10, 2017 · 2 comments
Closed

Refactor buttons with Aphrodite #7168

luixxiul opened this issue Feb 10, 2017 · 2 comments
Assignees
@luixxiul @cezaraugusto
Labels
misc/button needs-info Another team member needs information from the PR/issue opener. refactoring/aphrodite release-notes/exclude wontfix

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 10, 2017 •
edited
Loading

Describe the issue you encountered: /js/components/button.js is called so many places that refactoring it will help other stuff to be refactored as well :-)
@luixxiul luixxiul added this to the 0.13.4 milestone Feb 10, 2017
@luixxiul
Copy link
Contributor Author

I added priority/high label (as the refactor is needed by #6785) with release/not-blocking.

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 14, 2017
This was referenced Apr 29, 2017
Merged
Closed
@luixxiul luixxiul mentioned this issue Sep 14, 2017
Closed
8 tasks
@luixxiul
Copy link
Contributor Author

This ticket can be closed as well as #9071 after navItem is added, though I am not quite sure which button corresponds to that.

https://github.com/luixxiul/browser-laptop/blob/96c6445d04a8ddccaf0bbb6fac6bfa0a00d9c428/app/renderer/components/common/browserButton.js#L29

      // this.props.navItem && styles.browserButton_navItem,

@cezaraugusto do you have an idea?

@luixxiul luixxiul added release-notes/exclude needs-info Another team member needs information from the PR/issue opener. labels Sep 24, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

@cezaraugusto cezaraugusto

Labels
misc/button needs-info Another team member needs information from the PR/issue opener. refactoring/aphrodite release-notes/exclude wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @cezaraugusto @bsclifton