Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Can't add folder in bookmarks. #7229

Closed
siemiatj opened this issue Feb 13, 2017 · 5 comments
Closed

Can't add folder in bookmarks. #7229

siemiatj opened this issue Feb 13, 2017 · 5 comments
Labels
bug feature/bookmarks QA/checked-Win32 QA/test-plan-specified regression release-notes/exclude
Milestone
0.13.3

Comments

@siemiatj
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    Yes
  • Describe the issue you encountered:

Not sure if this doesn't work only when you have no additional bookmarks folders or it's some regression but I can't add a folder in bookmarks manager. Clicking the icon pops up a modal that looks exactly like bookmark adding modal and filling name input still doesn't make the button active. Gif file attached. Is it a regression ?

  • Platform (Win7, 8, 10? macOS? Linux distro?):

OSX 10.11.6

  • Brave Version (revision SHA):

0.13.3.36ee225

  • Steps to reproduce:

    1. Go to Bookmark Manager
    2. Try adding a new folder
    3. Fail badly

  • Actual result:

Modal looks incorrect and doesn't allow adding bookmark.

  • Expected result:

Show modal with different message and add a bookmark folder.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes, fresh profile.

  • Is this an issue in the currently released version?

Not in 0.13.2.

  • Can this issue be consistently reproduced?

Apparently yes.

  • Extra QA steps:

  • Screenshot if needed:

bookmarks

  • Any related issues:
@michalbe
Copy link
Contributor

michalbe commented Feb 14, 2017 •
edited
Loading

This was probably caused by commit 6befe33994c5 since it works with the previous one (commit b9e4ed0583).

@siemiatj
Copy link
Contributor Author

If this is confirmed I'm more than happy to fix it.

@ayumi
Copy link
Contributor

ayumi commented Feb 14, 2017

can repro at bcbafec, MacOS, fresh profile

@luixxiul
Copy link
Contributor

On Windows 10 the issue cannot reproduced. It may be specific to macOS

@cndouglas
Copy link

Reproduced with latest master (bcbafec) on macOS 10.12.x with a fresh profile.

image

Right-click bookmarks toolbar > Add Folder does not work either. There is apparently no way to create bookmarks folders.

Tagging this as blocking for 0.13.3. Please change if needed.

@cndouglas cndouglas added this to the 0.13.3 milestone Feb 14, 2017
cndouglas referenced this issue Feb 14, 2017
@bbondy
Site entries without a folderId should not be considered bookmark fol…
6befe33 
…ders

This code has gone through a lot of changes so it could be an old bug
which doesn't exist anymore.

This was causing a crash due to infinite call stack when creating the
bookmark menu.

Fix #7222

Auditors: @darkdh

I don't know why that entry exists but I couldn't find a reason within an acceptable period of time so I'm moving on
@bbondy bbondy closed this as completed in 27f447f Feb 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/bookmarks QA/checked-Win32 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.13.3
Development

No branches or pull requests
5 participants
@michalbe @siemiatj @ayumi @luixxiul @cndouglas