Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed open browser console (Shift+F8) #7448

Closed
srirambv opened this issue Mar 2, 2017 · 13 comments
Closed

Fixed open browser console (Shift+F8) #7448

srirambv opened this issue Mar 2, 2017 · 13 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 2, 2017

Test plan

  1. Launch Brave (0.14.0 preview 1 or newer)
  2. Press shift+F8 to launch the electron/muon dev tools
  3. Confirm they appear, docked on the right

Description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Unable to open Browser Console (Shift+F8)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 0e68342

  • Steps to reproduce:

    1. Do a clean install of 0.13.5 RC1
    2. Press Shift+F8
    3. Browser console is not opened
  • Actual result:
    Browser console is not opened

  • Expected result:
    Should open browser console when keyboard shorcut is pressed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    devconsole

  • Any related issues:

@NejcZdovc
Copy link
Contributor

I tried it on macOS with the latest version from the master c198994 and it's working correctly. Will try with windows now

@NejcZdovc
Copy link
Contributor

Tested on a windows VM and it's working correctly

image

cc @bsclifton can you try it out?

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 2, 2017

@srirambv can you retry it with the current master version?

@bsclifton bsclifton modified the milestones: 0.13.6, 0.13.5 Mar 2, 2017
@bsclifton
Copy link
Member

Removed blocker label, since the electron/Muon devtools aren't needed (the content dev tools still work fine, right?). Also moved to 0.13.6

@srirambv
Copy link
Collaborator Author

srirambv commented Mar 2, 2017

@NejcZdovc Works when I build off master. Not on the RC build.

@srirambv
Copy link
Collaborator Author

srirambv commented Mar 2, 2017

@bsclifton Yes dev tools works just not browser console.

@bsclifton
Copy link
Member

was able to repro on 0.13.5, RC2

@bsclifton
Copy link
Member

Not able to repro on completely fresh npm install on that same box with latest from master 🤔

@NejcZdovc
Copy link
Contributor

@bsclifton @srirambv can you try it out with the latest 0.13.5 RC3?

@srirambv
Copy link
Collaborator Author

srirambv commented Mar 3, 2017

@NejcZdovc Not working on 0.13.5 RC3 as well.

@NejcZdovc NejcZdovc removed their assignment Mar 10, 2017
@NejcZdovc
Copy link
Contributor

I think this is not working with a packaged version, it's working with a dev master.

@bsclifton
Copy link
Member

Not a show stopper; moving to 0.13.7 (needs more investigation)

@bsclifton bsclifton added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 13, 2017
@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 13, 2017
@bsclifton
Copy link
Member

Fixed with 5a889cc

@bsclifton bsclifton added this to the 0.14.0 milestone Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.