Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed display of session info on tab #7716

Closed
srirambv opened this issue Mar 14, 2017 · 1 comment
Closed

Fixed display of session info on tab #7716

srirambv opened this issue Mar 14, 2017 · 1 comment

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 14, 2017

Test Plan:

  • Open new session tab
  • Click on a target="_blank" link
  • New tab should have only numbers and not partition- string on its tab

#7741 (comment)


Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Partition text for session tab is overlapping on the tab title

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev 7dfeeb0

  • Steps to reproduce:

    1. Do a clean install of 0.14.0
    2. Visit a site in a new session tab
    3. Open a link in new tab from the session tab
    4. The text partition is overlapping on the tab title (see screenshot)
  • Actual result:
    Partition text for session tab is overlapping on the tab title

  • Expected result:
    Should not over lap on tab title

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:

@alexwykoff
Copy link
Contributor

screen shot 2017-03-29 at 8 14 19 pm

This is the current expectation, where purple only shows for the active private tab. Future design will have a purple hint for inactive tabs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants