Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed default browser setting Ubuntu #7800

Closed
CliqueBait opened this issue Mar 21, 2017 · 5 comments
Closed

Fixed default browser setting Ubuntu #7800

CliqueBait opened this issue Mar 21, 2017 · 5 comments

Comments

@CliqueBait
Copy link

CliqueBait commented Mar 21, 2017

Test Plan

  1. Make sure you don't have gawk installed on linux
  2. Make sure Brave is ont your default browser
  3. Install Brave
  4. Launch Brave and set it as default browser in app
  5. Brave should be your default browser

Original issue description

Brave: 0.13.5
rev: 1db81cb
Muon: 2.56.8
libchromiumcontent: 56.0.2924.87
V8: 5.6.326.50
Node.js: 7.4.0
Update Channel: dev
os.platform: linux
os.release: 4.8.0-42-generic
os.arch: x64

I recently switched from using Ubuntu/Unity to Ubuntu/XFCE. I have Brave set as the default browser but Brave doesn't seem able to recognise this on startup so I get prompted about that every single startup. However, other applications do start Brave or use an existing instance when opening urls.

image

@jonathansampson
Copy link
Collaborator

Confirmed.

ubuntu-default

@darkdh darkdh self-assigned this Apr 2, 2017
@cndouglas cndouglas changed the title Ubuntu/XFCE: Brave doesn't know that it's the default browser. Ubuntu: Brave doesn't know that it's the default browser. Apr 3, 2017
@cndouglas
Copy link

Based on @jonathansampson's screencast (Unity), this may be a problem with any desktop environment on Ubuntu.

@jonathansampson
Copy link
Collaborator

@bbondy Reported seeing this as well. @darkdh was able to repro with a fresh install.

@alexwykoff alexwykoff changed the title Ubuntu: Brave doesn't know that it's the default browser. Fixed default browser setting Ubuntu Apr 25, 2017
@CliqueBait
Copy link
Author

I don't think this is fixed. Also, is step 1 of the Test Plan really asking me to uninstall gawk (a core utility in linux systems) ?

@darkdh
Copy link
Member

darkdh commented Apr 27, 2017

Sorry, the test steps is a little confusing.
Step 1 is make sure you don't have gawk in your system. When you install Brave, it will show you that you need to install gawk as dependency.
Before this, we didn't ask user to install gawk. So it will fail to set as default silently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.