You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Side note about the implementation, please move window.chrome.extension.inIncognitoContext outside of the component to make the component more unit testable without mocking. I.e. pass it in as props.
@bradleyrichter, I like Firefox's new private tab page, in particular props for this line:
Private Browsing doesn’t make you anonymous on the Internet. Your employer or Internet service provider can still know what page you visit.
And also that they say what will be stored and what won't explicitly. The same applies to us.
No controls for this round please (like controlling tracking protection like firefox has). Only a nice looking page with info.
The text was updated successfully, but these errors were encountered:
Fix#7912
- Main frame loads are not allowed with spanning incognito mode, so
changed to split.
Sync shouldn't be allowed in incognito, so disabled that.
- Added handling in ledger to not log pages for private tabs.
Auditors: @bridiver
Test plan
See #8074
Description
Since cc51723 we have the ability to render new tab pages for private tabs.
js/about/newtab.js
can do this here:Please display a page that @bradleyrichter specs out.
Side note about the implementation, please move
window.chrome.extension.inIncognitoContext
outside of the component to make the component more unit testable without mocking. I.e. pass it in as props.@bradleyrichter, I like Firefox's new private tab page, in particular props for this line:
And also that they say what will be stored and what won't explicitly. The same applies to us.
No controls for this round please (like controlling tracking protection like firefox has). Only a nice looking page with info.
The text was updated successfully, but these errors were encountered: