Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add a new tab page for private tabs #7934

Closed
bbondy opened this issue Mar 28, 2017 · 0 comments
Closed

Add a new tab page for private tabs #7934

bbondy opened this issue Mar 28, 2017 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Mar 28, 2017

Test plan

See #8074

Description

Since cc51723 we have the ability to render new tab pages for private tabs.

js/about/newtab.js can do this here:

   if (window.chrome.extension.inIncognitoContext) {
    return <div className='empty' />
  }

Please display a page that @bradleyrichter specs out.

Side note about the implementation, please move window.chrome.extension.inIncognitoContext outside of the component to make the component more unit testable without mocking. I.e. pass it in as props.


@bradleyrichter, I like Firefox's new private tab page, in particular props for this line:

Private Browsing doesn’t make you anonymous on the Internet. Your employer or Internet service provider can still know what page you visit.

And also that they say what will be stored and what won't explicitly. The same applies to us.

No controls for this round please (like controlling tracking protection like firefox has). Only a nice looking page with info.

@bbondy bbondy added this to the 0.14.2 milestone Mar 28, 2017
bbondy referenced this issue Mar 28, 2017
Fix #7912

- Main frame loads are not allowed with spanning incognito mode, so
  changed to split.
  Sync shouldn't be allowed in incognito, so disabled that.
- Added handling in ledger to not log pages for private tabs.

Auditors: @bridiver
@cezaraugusto cezaraugusto mentioned this issue Apr 5, 2017
4 tasks
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.3 Apr 7, 2017
@alexwykoff alexwykoff changed the title Add a new tab page for private tabs Added a new tab page for private tabs Apr 25, 2017
@luixxiul luixxiul changed the title Added a new tab page for private tabs Add a new tab page for private tabs Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.