Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update header style on about:preferences pages #8165

Closed
bsclifton opened this issue Apr 10, 2017 · 4 comments
Closed

Update header style on about:preferences pages #8165

bsclifton opened this issue Apr 10, 2017 · 4 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 10, 2017

Test plan

#8237 (comment)

  1. Open about:preferences#search
  2. Make sure there is margin under the top header

When reviewing the Extensions page, I noticed that the header style didn't match the other pages:
prefs-top

The orange style looks great though- we should consider putting this style on the top of each page (possibly with a description of what the page has).

Here's the page where I noticed the new style (which looks great)
screen shot 2017-04-09 at 10 21 57 pm

cc: @bradleyrichter @cezaraugusto @luixxiul

@bsclifton bsclifton added design A design change, especially one which needs input from the design team. needs-info Another team member needs information from the PR/issue opener. labels Apr 10, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Apr 10, 2017

IMO creating custom elements as I did for commonForm would solve the inconsistency issue like this.

@cezaraugusto
Copy link
Contributor

@luixxiul mind grabbing this?

@luixxiul
Copy link
Contributor

@cezaraugusto no problem, I'm taking it.

@luixxiul
Copy link
Contributor

To change the "extensions" header into the orange one, we would at first need to add the same type of header to other tabs such as about:preferences#searchand about:preferences#plugins. Otherwise it would lead additional style inconsistency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants