Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed jumpy tab drag and drop #8288

Closed
srirambv opened this issue Apr 13, 2017 · 8 comments
Closed

Fixed jumpy tab drag and drop #8288

srirambv opened this issue Apr 13, 2017 · 8 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 13, 2017

Old title: Tab drag and drop can be jumpy

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Tab drag has bad animation before dropping the tab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.2
    rev f07c142

  • Steps to reproduce:

    1. Have multiple tabs opened
    2. Drag one of the tab and try to place between two tabs
    3. Shows bad animation
  • Actual result:
    Tab drag has bad animation before dropping the tab

  • Expected result:
    Shuould not behave like that

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    May be. Subtle difference between tear off and tab drag might have caused this

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    tabmovement

  • Any related issues: when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled (follow-up of #6033) #6863
    cc: @bbondy @bsclifton

@bsclifton
Copy link
Member

Closing as a duplicate of #6242

@bsclifton bsclifton added the duplicate Issue has already been reported label Apr 19, 2017
@bsclifton
Copy link
Member

Reopening- this is really bad on Windows

@bsclifton bsclifton reopened this Apr 21, 2017
@bsclifton bsclifton added OS/Windows and removed duplicate Issue has already been reported release/not-blocking labels Apr 21, 2017
@bsclifton bsclifton added this to the 0.15.0 milestone Apr 21, 2017
@Jacalz
Copy link
Contributor

Jacalz commented Apr 22, 2017

I suggest having a ui like chrome where you slide the tabs over, hard to explain in text but take a look at chrome and you will understand 😉👍

@bsclifton
Copy link
Member

bsclifton commented Apr 22, 2017

@Jacalz for sure 😄 that requirement is captured with #6242

This issue is capturing how the tab is moving so crazy fast when dragging, but only on Windows. Definitely a bug

@bbondy bbondy changed the title Tab drag has bad animation before dropping the tab Tab drag and drop can be jumpy Apr 22, 2017
@bbondy
Copy link
Member

bbondy commented Apr 23, 2017

Fixed #8436

@bbondy bbondy closed this as completed Apr 23, 2017
@luixxiul luixxiul added QA/test-plan-required release-notes/include and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Apr 23, 2017
@srirambv
Copy link
Collaborator Author

Still an issue on Windows 10 x64
8288

@srirambv srirambv reopened this Apr 24, 2017
@bbondy
Copy link
Member

bbondy commented Apr 24, 2017

new builds were not made for this yet were they?

@srirambv
Copy link
Collaborator Author

closing the issue as fix not included in RC3

@alexwykoff alexwykoff changed the title Tab drag and drop can be jumpy Fixed jumpy Tab drag and drop Apr 25, 2017
@alexwykoff alexwykoff changed the title Fixed jumpy Tab drag and drop Fixed jumpy tab drag and drop Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.