Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make bookmarks items' list fixed #8607

Closed
cezaraugusto opened this issue May 1, 2017 · 3 comments
Closed

Make bookmarks items' list fixed #8607

cezaraugusto opened this issue May 1, 2017 · 3 comments
Labels
feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. wontfix

Comments

@cezaraugusto
Copy link
Contributor

PR #8532 addressed some issues regarding bookmarks but fixed header for item's list was left. That's because list uses SortableTable, and per spec tables aren't supposed to have overflow.

Screenshot credits of @jonathansampson:
34e194a0-2c1d-11e7-8075-698d262c317c

Ideally, items' header (right-hand side) should be fixed.

In order to fix that, SortableTable should be either fully refactored to make use of CSS grid or flagged at some point that other element than <table> (and its children) should be used.

Labelled as backlog feel free to remove if needed

@cezaraugusto
Copy link
Contributor Author

Removing good-first-bug since refactoring SortableTable can be tricky. Feel free to ping me anyone willing to take it.

@cezaraugusto cezaraugusto added polish Nice to have — usually related to front-end/visual tasks. and removed bug/good-first-bug labels May 1, 2017
@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@luixxiul
Copy link
Contributor

fyi there is an upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=702927 "position: sticky does not work on or ". Since sortableTable will be deprecated with another component, it'll be not an issue for us.

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Removing from backlog. Not an issue in brave-core.

@rebron rebron removed this from the Triage Backlog milestone Sep 9, 2018
@rebron rebron added the wontfix label Sep 9, 2018
@rebron rebron closed this as completed Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. wontfix
Projects
None yet
Development

No branches or pull requests

5 participants