Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab preview causes the tab content to be still shown as a preview rather than loading the content #8842

Closed
srirambv opened this issue May 11, 2017 · 1 comment

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 11, 2017

Test plan

  1. Open couple of tabs with an about page
  2. Hove over the tab title to show preview
  3. Click on the hovered tab
  4. Content should not show as preivew

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Tab preview causes the tab content to be still shown as a preview rather than loading the content

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.15.302
    rev 81fd962

  • Steps to reproduce:

    1. Open couple of tabs with an about page
    2. Hove over the tab title to show preview
    3. Click on the hovered tab, content still shows as preivew. Hover back and click on the active tab shows the content properly
    4. About pages still remains as tab preview even after clicking on next tab
  • Actual result:
    Tab preview causes the tab content to be still shown as a preview rather than loading the content

  • Expected result:
    Tab preview and tab content should be properly shown

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image
    tabpreview
    image
    Console Log

[10732:4108:0511/200400.598:ERROR:CONSOLE(19773)] "Uncaught AssertionError: Could not find tab for 26", source: chrome://brave/C:/Users/Sriram%20BV/AppData/Local/brave/app-0.15.302/resources/app.asar/app/extensions/brave/gen/app.entry.js (19773)
[10732:4108:0511/200400.775:ERROR:CONSOLE(19773)] "Uncaught AssertionError: Could not find tab for 26", source: chrome://brave/C:/Users/Sriram%20BV/AppData/Local/brave/app-0.15.302/resources/app.asar/app/extensions/brave/gen/app.entry.js (19773)```

- Any related issues:
cc: @bsclifton 
@bsclifton
Copy link
Member

This was fixed this morning with 4211ee5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants