Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

close tab icon only shows for the last tab #8883

Closed
cezaraugusto opened this issue May 16, 2017 · 1 comment
Closed

close tab icon only shows for the last tab #8883

cezaraugusto opened this issue May 16, 2017 · 1 comment

Comments

@cezaraugusto
Copy link
Contributor

Opening more than one tab only shows close tab icon for the last tab. Commit issue was found going back in git history and resetting merge commit 1d5ba3f, (PR #8863).

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    any

  • Brave Version (revision SHA):
    3e3464e

  • Steps to reproduce:

    1. Open two tabs
    2. Make second active
    3. Hover over the first
  • Actual result:
    no close tab icon

  • Expected result:
    close tab icon should show for each tab preview at that tab size

  • Screenshot if needed:
    mouse wasn't recorded but preview indicates that it is over the first tab
    closetab_icon

cc @bridiver

@bridiver
Copy link
Collaborator

looks like another rebase/merge conflict issue, pushing a fix now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.