Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refine the Brave button (look, positioning, feel) on Windows #5069

Closed
bsclifton opened this issue Oct 23, 2016 · 6 comments · Fixed by #5522
Closed

Refine the Brave button (look, positioning, feel) on Windows #5069

bsclifton opened this issue Oct 23, 2016 · 6 comments · Fixed by #5522

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 23, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
The Brave button (the lion icon) feels awkward on Windows (compared to the macOS version)
screen shot 2016-10-23 at 12 44 31 am

Expected behavior:
Solution should match this mockup by @bradleyrichter:
image

Notice:

  • the caption buttons are vertically centered
  • lion icon has an additional separator to the right

Related:
Similar to #4591

@bsclifton
Copy link
Member Author

bsclifton commented Oct 23, 2016

@bradleyrichter When implementing, I discovered an issue with this design:
windows1

The caption buttons have their vertical centering throw off on resize ☹️

For a demo, I tried putting the menu UNDER the navigation bar. This looks and feels pretty decent 😄
windows2

This is consistent w/ IE behavior too:
windows3

What do you all think? (cc: Windows users- @srirambv @jonathansampson). The styles can be updated to look halfway decent (matching Bookmarks Toolbar)
screen shot 2016-10-23 at 2 19 41 am

@bsclifton bsclifton added the design A design change, especially one which needs input from the design team. label Oct 23, 2016
@srirambv
Copy link
Collaborator

@bsclifton The file menu popping under the URL bar looks good. +1 for this to go with Windows build.

If this behavior is implemented then I would suggest to disable Always show menu bar.

@bsclifton
Copy link
Member Author

Moving this to 0.12.8; I know @bradleyrichter is still finalizing the placement- I like it under the menus too 😄 It would be good to see what the public thinks

@bsclifton bsclifton modified the milestones: 0.12.8dev, 0.12.7dev Oct 24, 2016
@bsclifton
Copy link
Member Author

Moving to 0.12.9. We did talk over Slack and have worked out an ideal scenario:

  • screenshots in original post is accurate
  • menu will NOT move beneath the nav bar (this is not standard)
  • Brave logo and extensions will go under the caption buttons if menu is being shown

@bsclifton bsclifton modified the milestones: 0.12.9dev, 0.12.8dev Oct 31, 2016
@bsclifton
Copy link
Member Author

Here are some WIP screenshots, cc: @bradleyrichter

no menu w/ magic titlebar
screen shot 2016-11-05 at 12 45 53 am

menu w/ magic titlebar
screen shot 2016-11-05 at 12 46 38 am

no menu w/ URL bar
screen shot 2016-11-05 at 12 47 35 am

menu w/ URL bar
screen shot 2016-11-05 at 12 47 14 am

@bsclifton bsclifton removed the design A design change, especially one which needs input from the design team. label Nov 8, 2016
@bsclifton bsclifton reopened this Nov 9, 2016
@bsclifton
Copy link
Member Author

Re-opening after testing on Windows 7 (see screenshot)

Working on a fix now...

screen shot 2016-11-09 at 12 12 50 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants