Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disabling adblock in private tab still shows the adblock count #5376

Closed
srirambv opened this issue Nov 3, 2016 · 4 comments · Fixed by #5481
Closed

Disabling adblock in private tab still shows the adblock count #5376

srirambv opened this issue Nov 3, 2016 · 4 comments · Fixed by #5481
Assignees
@darkdh
Labels
feature/adblock feature/private-tabs QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 3, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Disabling adblock in private tab still shows the adblock count

Expected behavior:
Should not show the adblock count when adblock is disabled in a private tab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.12.8 preview 3

  • Steps to reproduce:

    1. Open any link in a private tab
    2. Check the adblock count
    3. Disable adblock from shields, still shows the adblock count

  • Screenshot if needed:
    privatewindow

  • Any related issues:
@srirambv srirambv added this to the 0.12.8dev milestone Nov 3, 2016
@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

Moving to 0.12.9 but cc @darkdh seems like a bug with per site private tabs data

@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.8dev Nov 4, 2016
@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

I suspect it's not a regression btw, did you confirm it worked in 0.12.7 @srirambv ?

@srirambv
Copy link
Collaborator Author

srirambv commented Nov 4, 2016

No missed it my bad. Removing regression

@darkdh darkdh self-assigned this Nov 7, 2016
@bbondy
Copy link
Member

bbondy commented Nov 8, 2016

Moving to 0.12.10.

@bbondy bbondy modified the milestones: 0.12.10 release , 0.12.9dev Nov 8, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Nov 8, 2016
@darkdh
isResourceEnabled for private tab
78f9307 
fix brave#5376

Auditors: @bbondy, @bridiver

Test Plan:
1. Go to slashdot.org in regular tab
2. Toggle ad control to see the effect
3. Go to slashdot.org in private tab
4. Tab in step 3 should inherit the state of step1
5. Toggle ad control to see the effect
6. Action in private tab will not affect regular tab
@darkdh darkdh modified the milestones: 0.12.9dev, 0.12.10 release Nov 8, 2016
@darkdh darkdh mentioned this issue Nov 8, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/adblock feature/private-tabs QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

isResourceEnabled for private tab darkdh/browser-laptop
5 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv