Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove panics from library code #156

Open
rillian opened this issue Oct 27, 2022 · 0 comments
Open

remove panics from library code #156

rillian opened this issue Oct 27, 2022 · 0 comments

Comments

@rillian
Copy link
Contributor

rillian commented Oct 27, 2022

There are a number of unwrap or expect assertions in the STAR implementation. Where these handle input coming from outside the library--n particular user or untrusted network data--it's important to report an error instead so the calling application can handle it gracefully rather than crashing.

Triggering a panic is fine on locally-controlled input, or in test code. Other use should be audited and converted to a Result return value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant