Issue 407 #439
Open
Issue 407 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 18 18
Lines 472 472
=======================================
Hits 471 471
Misses 1 1 ☔ View full report in Codecov by Sentry. |
melissawm
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Oi @FloraSauerbronn ! Uma dica, coloque um título descritivo na sua PR pra aumentar as chances de revisão (tipo "Adiciona uso sugerido do comando pip na documentação")
Aí, na descrição da PR vc pode usar um dos atalhos do github tipo Closes #407 pra ligar sua PR à issue original, e fechar a issue automaticamente quando sua PR for mesclada.
De resto, tá ótimo 😄
|
@melissawm obrigada pelas dicas ! Ficarei atenta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adiciona uso sugerido do comando pip na documentação
Descrição
Resolvendo o issue de documentação de instalação com pip
Mudanças Propostas
Adicionei a sessão de instalação com pip nos arquivos CONTRIBUTING.md e CONTRIBUTING_EN.md
Criei um requirements-dev.txt, pois não foi possível realizar a instalação das dependencias somente utilizando o pyproject.toml.
Checklist de Revisão
Comentários Adicionais (opcional)
Segue esse link de um post da comunidade python justificando meu PR
Why doesn’t pip write installed packages to pyproject.toml?
Issue Relacionada
Issue 407
Closes #407