You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this part of the code is affected by a memory leak.
In the pointed functions, you're using result but you're not freeing it. I don't know completely if that's a memory leak, but as I see how xlsxioread_sheet_next_cell works, I think it is. Correct me if I am wrong.
Thanks.
The text was updated successfully, but these errors were encountered:
Hi, XLSXIOCHAR* xlsxioread_sheet_next_cell (xlsxioreadersheet sheethandle) returns a string which the caller needs to call free() on, so the function does exit without releasing that memory.
But it's up to the caller to release it to prevent memory leaks in this case.
So I did notice that xlsxioread_sheet_next_cell_int/xlsxioread_sheet_next_cell_float/xlsxioread_sheet_next_cell_datetime didn't call free(result);
I have added it now in master.
Thanks for spotting this.
Brecht
Hello,
I think this part of the code is affected by a memory leak.
In the pointed functions, you're using
result
but you're not freeing it. I don't know completely if that's a memory leak, but as I see howxlsxioread_sheet_next_cell
works, I think it is. Correct me if I am wrong.Thanks.
The text was updated successfully, but these errors were encountered: