Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CloudFormation action in CodePipeline to push stack outputs to an optional output artifact #19

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

john-shaskin
Copy link
Collaborator

I'm being lazy and combining two changes into one PR here.

  1. Adding ECR permissions to the roles used for CloudFormation and CodeBuild
  2. Adding ability to optionally specify an output artifact name in a CloudFormation action, which will cause the stack output values to be pushed into a JSON file that is output for successive pipeline actions to access.

@brettswift brettswift self-requested a review October 5, 2018 14:15
Copy link
Owner

@brettswift brettswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created an issue that is less related to this PR and more to the work I'm doing, however because this code touches the same area (adding action_mode to the cfn step), I wanted to raise it here, even though I'm approving for merge.

#20

Ultimately, I think the best route might be to take items like the configuration object, and allow that to be overridden, instead of having to pick apart all the properties of it individually.. like action_mode, as we would inevitably end up with a constructor signature with 30 parameters.

We just need to figure out a direction after learning from writing a few different troposphere examples.

@brettswift brettswift merged commit 152d09d into brettswift:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants