Enable optional S3 bucket creation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettswift
force-pushed
the
feature/pipeline_separate_bucket_step
branch
2 times, most recently
from
58616c5
to
791eabb
Compare
This enables pipelines to create their own, and gives more flexibility to the release cycle when using tooling that doesn't clear out s3 buckets for you. Also allows you to use a bucket from another account.
brettswift
force-pushed
the
feature/pipeline_separate_bucket_step
branch
from
791eabb
to
b47384f
Compare
john-shaskin
approved these changes
Oct 25, 2018
| from cumulus.chain import step | ||
|
|
||
|
|
||
| class S3Bucket(step.Step): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables pipelines to create their own, and gives more flexibility
to the release cycle when using tooling that doesn't clear out
s3 buckets for you. Also allows you to use a bucket from another
account.