Support for injectable cloudformation roles #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettswift
force-pushed
the
feature/cross_account_codebuild_support
branch
from
5372bbf
to
e466dfd
Compare
jsauter
approved these changes
Nov 2, 2018
john-shaskin
approved these changes
Nov 2, 2018
brettswift
force-pushed
the
feature/cross_account_codebuild_support
branch
from
e466dfd
to
1fb05e2
Compare
Add validation check for pipeline when code build is added out of order Give codebuild access to codepipeline Revert name of pipeline Add missing package Add user parameters to lambda pipeline step
brettswift
force-pushed
the
feature/cross_account_codebuild_support
branch
from
1fb05e2
to
7e7a00c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cross account activity hit a lot of areas. This PR is an accumulation of each area that had to be tweaked to get this to work.
It's big and klunky. Typically I would like to have these broken down into atomic pieces with context on each one. Two PR's were made to precede this one however we're now left with this. Hopefully it's not too arduous to get through.
Beyond support for injectable cloudformation roles the following was added:
Add validation check for pipeline when code build is added out of order
Give codebuild access to codepipeline
Add missing package
Add user parameters to lambda pipeline step
and more!