Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export controls in chewie.dart. #355

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Conversation

HiIamAlanOu
Copy link
Contributor

I want to use the MaterialControls and CupertinoControls in customControls parameter.

_chewieController = ChewieController(
videoPlayerController: _videoPlayerController,
aspectRatio: 3 / 2,
autoInitialize: true,
customControls: MaterialControls(),
);

Use MaterialControls to avoid this problem(#354) on iOS.

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 8, 2020

This doesn't happen on my emulator (IPhone 12 Pro Max) and on my physical IPhone 11 Pro. Did you checked out the latest release? Some changes came in, in the last days :)

@HiIamAlanOu
Copy link
Contributor Author

Still have the same problem on my emulator (IPhone 12 Pro Max) and on my physical IPhone SE.
But the problem only exists on the time bar widget this time.
I demonstrated the code on this link.( https://github.com/HiIamAlanOu/web_and_video )
image

@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 18, 2020

Still have the same problem on my emulator (IPhone 12 Pro Max) and on my physical IPhone SE.

But the problem only exists on the time bar widget this time.

I demonstrated the code on this link.( https://github.com/HiIamAlanOu/web_and_video )

image

Hmm, okay If that's the case encapsulation is blocking important stuff here. Alright I'll update this 👍🏼

@Ahmadre Ahmadre merged commit 2c3b1c8 into fluttercommunity:master Nov 19, 2020
@Ahmadre
Copy link
Collaborator

Ahmadre commented Nov 19, 2020

Thanks @HiIamAlanOu

@nstrelow
Copy link
Collaborator

This PR did not pass the linting.
But somehow the checks were not executed here.
Strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants